[PATCH] D84038: Passing the flag bigobj globally when building debug compiler on Windows

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a reviewer: beanz.
aaron.ballman added a subscriber: beanz.
aaron.ballman added a comment.

I think this is missing changes to `clang\lib\ARCMigrate\CMakeLists.txt(8): set_source_files_properties(Transforms.cpp PROPERTIES COMPILE_FLAGS /bigobj)`.



================
Comment at: clang/CMakeLists.txt:416
 
+if (MSVC)
+   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj")
----------------
Is this change actually needed? I would have assumed that Clang was inheriting the compile options from LLVM automatically?


================
Comment at: llvm/CMakeLists.txt:603
 
+if (MSVC)
+   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj")
----------------
I would expect to find these changes in HandleLLVMOptions.cmake somewhere around line 390 (where we're setting up the other global MSVC flags), but I'm not the expert in our CMake. @beanz, what say you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84038/new/

https://reviews.llvm.org/D84038