[PATCH] D84132: [LLVMgold.so] -plugin-opt=save-temps: save combined module to .lto.o instead of .o

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

In D84132#2164675 <https://reviews.llvm.org/D84132#2164675>, @MaskRay wrote:

> In D84132#2164644 <https://reviews.llvm.org/D84132#2164644>, @bjope wrote:
>
> > Having some problems with failing stage 2 tests, that I suspect is related to this change (since the missing files do exist but with ".lto" being part of the name when looking in my test directory after a failed test run). I guess on need to add ".lto" at some more places?
> >
> > These are the tests that failed:
> >
> >   Failed Tests (3):
> >     LLVM :: tools/gold/X86/cache.ll
> >     LLVM :: tools/gold/X86/emit-llvm.ll
> >     LLVM :: tools/gold/X86/relax-relocs.ll
> >
> >
> > Here are some logs:
> >
> >   : 'RUN: at line 70';   ls /build/stage2/test/tools/gold/X86/Output/cache.ll.tmp4.o.o1
> >   : 'RUN: at line 71';   ls /build/stage2/test/tools/gold/X86/Output/cache.ll.tmp4.o.o2
> >   --
> >   Exit Code: 2
> >  
> >   Command Output (stderr):
> >   --
> >   ls: cannot access /build/stage2/test/tools/gold/X86/Output/cache.ll.tmp4.o.o1: No such file or directory
> >
> >
> >
> >
> >   Exit Code: 2
> >  
> >   Command Output (stderr):
> >   --
> >   /build/stage2/bin/llvm-nm: error: /build/stage2/test/tools/gold/X86/Output/emit-llvm.ll.tmp3.o.o: No such file or directory.
> >   FileCheck error: '<stdin>' is empty.
> >   FileCheck command line:  /build/stage2/bin/FileCheck --check-prefix=NM /llvm-project/llvm/test/tools/gold/X86/emit-llvm.ll
> >
> >
> >
> >
> >   Exit Code: 2
> >  
> >   Command Output (stderr):
> >   --
> >   /build/stage2/bin/llvm-readobj: error: '/build/stage2/test/tools/gold/X86/Output/relax-relocs.ll.tmp.so.o': No such file or directory
> >   FileCheck error: '<stdin>' is empty.
> >   FileCheck command line:  /build/stage2/bin/FileCheck /llvm-project/llvm/test/tools/gold/X86/relax-relocs.ll
> >
>
>
> Thanks for reporting the problem. Fixed by aa830e9768303ff8d27c015759294c4ce704d50c <https://reviews.llvm.org/rGaa830e9768303ff8d27c015759294c4ce704d50c> (I should have been more careful. Not many build bots build binutils-gdb headers and test LLVMgold.so)


Ok, thanks! It did not cause a big problem for me though. I was just checking our downstream bots and happened to notice some failures (and maybe those bots are a bit "pedantic" because I don't think we currently use that setup in production).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84132/new/

https://reviews.llvm.org/D84132