[PATCH] D84191: [llvm-objdump] Symbolize binary addresses for low-noisy asm diff.

Tue Jul 21 10:29:05 PDT 2020

hoyFB marked 2 inline comments as done.
hoyFB added a comment.

In D84191#2163668 <https://reviews.llvm.org/D84191#2163668>, @jhenderson wrote:

> Could you post some examples of what the actual difference in output is, please? I don't quite follow from the tests/description what is intended to change as a result of this option.
>
> Also, if you are adding a new option to llvm-objdump, please remember to document it in llvm/docs/CommandGuide/llvm-objdump.rst.

The main difference in output is to print branch target as labels instead of real addresses, also for PC-relative global references. I updated the summary. Please let me know if it is clear. Thanks.

================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-symbolize-operands.s:2
+# RUN: llvm-mc -filetype=obj %s -o %t
+# RUN: ld.lld %t -o %t2
+# RUN: llvm-objdump -d --symbolize-operands --x86-asm-syntax=intel --no-show-raw-insn --no-leading-addr %t2 | FileCheck %s
----------------
MaskRay wrote:
> lld is a subproject and depends on llvm. You cannot use ld.lld in llvm tests.
The original test seemed to pass. Did that end up using the pre-installed lld on the test machine?

 I switched to using a prebuilt binary instead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84191/new/

https://reviews.llvm.org/D84191