[PATCH] D84180: [Matrix] Add LowerMatrixIntrinsics to the NPM

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 09:43:18 PDT 2020


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! It would be good to also run EarlyCSE as mentioned inline.



================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1099
+  if (EnableMatrix)
+    OptimizePM.addPass(LowerMatrixIntrinsicsPass());
+
----------------
We should probably also run EarlyCSE afterwards (if EnableMatrix is true), to keep things in sync with the legacy PM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84180/new/

https://reviews.llvm.org/D84180





More information about the llvm-commits mailing list