[PATCH] D84056: [FPEnv] Don't transform FSUB(-0, X) -> FNEG(X) in SelectionDAGBuilder.

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 08:02:22 PDT 2020


cameron.mcinally updated this revision to Diff 279523.
cameron.mcinally added a comment.

Fix the FMED3 DAGCombine problem by explicitly adding the new node's users to the Worklist.

Heads up, @arsenm. There are other instances of this bug in `performFNegCombine(...)`. I see at least two in the other FMA cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84056/new/

https://reviews.llvm.org/D84056

Files:
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
  llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/test/CodeGen/AMDGPU/fdiv32-to-rcp-folding.ll
  llvm/test/CodeGen/AMDGPU/selectcc-opt.ll
  llvm/test/CodeGen/AMDGPU/set-dx10.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84056.279523.patch
Type: text/x-patch
Size: 8407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200721/72eb928b/attachment.bin>


More information about the llvm-commits mailing list