[PATCH] D84201: [LangRef] Add integer wrapping operand bundles.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/docs/LangRef.rst:2306
+
+
 .. _moduleasm:
----------------
jdoerfert wrote:
> [Drive By]
> 
> Should we add a reference to nuw/nsw specification (if we have one)?
> 
> I'm not sure the the description is explicit enough. `if
> unsigned and/or signed overflow, respectively, occurs`, where/when?
> 
> 
> Nit: I would say the type is spelled `i1` but I don't care much.
> Should we add a reference to nuw/nsw specification (if we have one)?

I don't think there is. AFAIK it is only specified in the semantics of the instructions taking nuw/nsw flags.

> I'm not sure the the description is explicit enough. `if unsigned and/or signed overflow, respectively, occurs`, where/when?

yeah, I should have been more explicit. I changed it to 

 the return value of the called function is a :ref:`poison value <poisonvalues>` if  unsigned and/or signed overflow, respectively, occurs during any computation the return value depends on in the called function (see value *dependence* as defined for :ref:`poison value <poisonvalues>`).

> Nit: I would say the type is spelled i1 but I don't care much.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84201/new/

https://reviews.llvm.org/D84201