[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

[Kirill Bobyrev via Phabricator via llvm-commits]

kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: llvm-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny.
Herald added a project: LLVM.

gRPC 1.26 and earlier are affected by bugs preventing remote index from working:

- https://github.com/grpc/grpc/issues/21280
- https://github.com/grpc/grpc/issues/21213

This patch sets minimum version of gRPC to 1.27 when it is installed manually
on the machine. It is unclear how to check version for system-installed gRPC
(which is probably more important) - maybe the right way would be compiling
dummy C++ file and printing the library version.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84232

Files:
  llvm/cmake/modules/FindGRPC.cmake


Index: llvm/cmake/modules/FindGRPC.cmake
===================================================================
--- llvm/cmake/modules/FindGRPC.cmake
+++ llvm/cmake/modules/FindGRPC.cmake
@@ -6,7 +6,7 @@
   set(protobuf_MODULE_COMPATIBLE TRUE)
   find_package(Protobuf CONFIG REQUIRED HINTS ${GRPC_INSTALL_PATH})
   message(STATUS "Using protobuf ${protobuf_VERSION}")
-  find_package(gRPC CONFIG REQUIRED HINTS ${GRPC_INSTALL_PATH})
+  find_package(gRPC 1.27 CONFIG REQUIRED HINTS ${GRPC_INSTALL_PATH})
   message(STATUS "Using gRPC ${gRPC_VERSION}")
 
   include_directories(${Protobuf_INCLUDE_DIRS})


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84232.279487.patch
Type: text/x-patch
Size: 600 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200721/ea180549/attachment.bin>