[PATCH] D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct

Tue Jul 21 04:50:53 PDT 2020

clementval added a comment.

In D83998#2163271 <https://reviews.llvm.org/D83998#2163271>, @ichoyjx wrote:

> Nice work on unifying two programming models' base attribute visitor. I am surprised that they could share most of the utils.
>
> As you could see, the OpenMP part was a WIP work and I only added the `PreDetermined` attribute. In the future, `ExpDetermined` (explicitly) and `ImpDetermined` (implicitly) attributes are also needed. Besides, we have "Data Mapping Attribute" for OpenMP, which will increase the complexity too. Do you picture that `OpenACC` and `OpenMP` would work together without an issue using this framework?

I guess the common base could be shared at least until now and I expect that it should be do-able with the additional attributes. Of course, I'm not against having two separate attribute visitor if we find it is needed when we add attributes in OpenMP and OpenACC. Was just trying to reduce the amount of code that was obviously duplicated in this case. Hopefully we can keep sharing this infra.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83998/new/

https://reviews.llvm.org/D83998