[PATCH] D84033: [llvm-readelf/readobj] - Refine the error reporting in printMipsABIFlags() methods.

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-abiflags.test:322
+# RUN: llvm-readobj -A %t.nosection 2>&1 | \
+# RUN:   FileCheck %s --check-prefixes=NOSEC,NOSEC-LLVM --implicit-check-not=warning:
+
----------------
jhenderson wrote:
> The implicit-check-not on the llvm-readobj case implies there is other output expected? What is this other output, and should we actually be checking it?
The full output is:

```
File: <file name here>
Format: elf64-mips
Arch: mips64el
AddressSize: 64bit
LoadName: <Not found>
There is no .MIPS.abiflags section in the file.
There is no .MIPS.options section in the file.
There is no .reginfo section in the file.
```

> should we actually be checking it?

It doesn't look like that to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84033/new/

https://reviews.llvm.org/D84033