[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 20 21:42:08 PDT 2020


aqjune added a comment.

In D83360#2162898 <https://reviews.llvm.org/D83360#2162898>, @craig.topper wrote:

> @aqjune did you put a patch for InstSimplify doing distribution over undef yet?


Sorry, making InstSimplify to safely distribute undef was a nontrivial job - other than updating InstSimplify to track uses, it needed rewinding folded undef records if simplification failed & update constant folding to track uses too. The folded value could be symbolic, making things more complex.
I'm trying an alternative solution for this problem, I will leave a link here after submission.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83360/new/

https://reviews.llvm.org/D83360





More information about the llvm-commits mailing list