[PATCH] D83519: [NewPM] Support optnone under new pass manager

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 20 21:16:40 PDT 2020


ychen accepted this revision.
ychen added a comment.
This revision is now accepted and ready to land.

LGTM with one nit.



================
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:57
 
+class OptNoneInstrumentation {
+public:
----------------
ychen wrote:
> I may probably name this `SkipPassInstrumentation`. But it is up to you.
Errr, let's go with `OptNoneInstrumentation ` if it's your preference. This is a bit too verbose IMHO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83519/new/

https://reviews.llvm.org/D83519





More information about the llvm-commits mailing list