[PATCH] D84094: [DebugInfo] Fix misleading using of DWARF forms with DIELabel. NFCI.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added a comment.

In D84094#2162466 <https://reviews.llvm.org/D84094#2162466>, @probinson wrote:

> It looks like you have been tweaking a number of related SizeOf() methods.  Is it practical to have just one?  In a parent class, or even as a free function (as the size computation depends only on form/format, and is not related to the class at all).


The idea is that `SizeOf()` should be in sync with `emitValue()`. If a value class accepts a DWARF form, i.e. `SizeOf()` does not break on `llvm_unreachable()`, it should emit the value in the specified way, corresponding to that form.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84094/new/

https://reviews.llvm.org/D84094