[PATCH] D83988: AMDGPU/GlobalISel: Start trying to handle AGPR bank

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:3144
+
+int AMDGPURegisterBankInfo::getMappingType(const MachineRegisterInfo &MRI,
+                                           const MachineInstr &MI) const {
----------------
madhur13490 wrote:
> arsenm wrote:
> > madhur13490 wrote:
> > > This function is returning 'int' but you're receiving it as 'unsigned'. As of now, this is fine but no need to have this discrepancy. I think it should be unsigned uniformly.
> > Really it should be an enum, but TableGen emits these as an anonymous enum right now
> Sure, but the type should be same either unsigned or int but not such discrepancy. This is bug prone. If tablegen's enum is unsigned then let this function return unsigned,
The enum is signed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83988/new/

https://reviews.llvm.org/D83988