[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:887
+  uint64_t Offset = 0;
+  unsigned ParmNum = 0;
+
----------------
Please reduce the scope of `ParmNum` by merging the adjacent blocks that set and use it.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:899
+  // parsing parameter type for vector info.
+  if (!Err && ParmNum > 0 && !hasVectorInfo())
+    ParmsType = parseParmsType(DE.getU32(&Offset, &Err), ParmNum);
----------------
Please add a comment that, as long as there are no "fixed-point" or floating-point parameters, this field remains not present even when `hasVectorInfo` gives `true` and indicates the presence of vector parameters.

This statement is true even when GCC counts vector (float!) parameters as "fixed-point" (and does not encode vector parameter information separately).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585