[PATCH] D84044: [AArch64][SVE] Add missing unwind info for SVE registers.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 20 21:16:34 PDT 2020
efriedma added a comment.
I'm confused by the stack layout involved here. SVE registers should never be callee-save. The ABI says we're only supposed to save the low 64 bits.
================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:469
+ uint8_t buffer[16];
+ SmallVector<uint8_t, 64> CfaExpr = {(int8_t)dwarf::DW_CFA_expression};
+ CfaExpr.append(buffer, buffer + encodeULEB128(DwarfReg, buffer));
----------------
Can you use a SmallString here, so you don't have to do weird pointer casts?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84044/new/
https://reviews.llvm.org/D84044
More information about the llvm-commits
mailing list