[PATCH] D84181: [NFC][GVN] Rewrite IsValueFullyAvailableInBlock()

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

> While this doesn't appear to help with the perf issue being exposed by D84108 <https://reviews.llvm.org/D84108>, the function as-is is very weird, convoluted, and what's worse, recursive.

Would it be possible to share the pre-GVN IR for the problematic case? (Independently of this cleanup, just curious)

> But i'm not sure instructions is *really* the right metric here, Because task-clock stat really improved, by -1.5% .. -5% all across the board.

This is just (very large) noise. I've added a disclaimer to the page that the task-clock/wall-time results are best ignored.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84181/new/

https://reviews.llvm.org/D84181