[PATCH] D81361: Make lit TestRunner.py work in Python 3

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 20 21:16:29 PDT 2020


compnerd added a comment.

I'm not sure if the early string conversion would work.  The problem is that the `\` replacement would escape the backreference.  So you end up with problems in the back-reference.  The wrapper ensures that they do not get replaced away as the path separator.

I agree with @tbkka about this being the most concise approach to solving the issue.

@gribozavr2, do you have any other suggestions on how to handle that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81361/new/

https://reviews.llvm.org/D81361





More information about the llvm-commits mailing list