[PATCH] D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values

[Xiangling Liao via Phabricator via llvm-commits]

Xiangling_L added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-complex.ll:1
+; RUN: llc -verify-machineinstrs \
+; RUN:  -mcpu=pwr4 -mattr=-altivec \
----------------
https://reviews.llvm.org/D78929#inline-740137
suggested how to format the command.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-complex.ll:11
+
+ at gcd1 = external global { double, double }, align 8
+ at gcd2 = external global { double, double }, align 8
----------------
It seems all `align xx` in this test are unnecessary, so you can simplify the testcase by removing them.

Also attributes like `noinline nounwind optnone` can be removed.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-complex.ll:19
+  %retval = alloca { double, double }, align 8
+  %gcd1.real = load double, double* getelementptr inbounds ({ double, double }, { double, double }* @gcd1, i32 0, i32 0), align 8
+  %gcd1.imag = load double, double* getelementptr inbounds ({ double, double }, { double, double }* @gcd1, i32 0, i32 1), align 8
----------------
#19 - #24 can be removed.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-complex.ll:60
+  %retval = alloca { float, float }, align 4
+  %gcf1.real = load float, float* getelementptr inbounds ({ float, float }, { float, float }* @gcf1, i32 0, i32 0), align 4
+  %gcf1.imag = load float, float* getelementptr inbounds ({ float, float }, { float, float }* @gcf1, i32 0, i32 1), align 4
----------------
line #60 - #65 can be removed


================
Comment at: llvm/test/CodeGen/PowerPC/aix-complex.ll:102
+  %retval = alloca { ppc_fp128, ppc_fp128 }, align 16
+  %gcld1.real = load ppc_fp128, ppc_fp128* getelementptr inbounds ({ ppc_fp128, ppc_fp128 }, { ppc_fp128, ppc_fp128 }* @gcld1, i32 0, i32 0), align 16
+  %gcld1.imag = load ppc_fp128, ppc_fp128* getelementptr inbounds ({ ppc_fp128, ppc_fp128 }, { ppc_fp128, ppc_fp128 }* @gcld1, i32 0, i32 1), align 16
----------------
#102 - #107 can be removed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84069/new/

https://reviews.llvm.org/D84069