[PATCH] D84081: AMDGPU: Fix not accounting for constantexpr uses of LDS globals
Michael Liao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 20 08:15:33 PDT 2020
hliao accepted this revision.
hliao added a comment.
This revision is now accepted and ready to land.
LGTM as a quick fix.
================
Comment at: llvm/test/CodeGen/AMDGPU/promote-alloca-to-lds-constantexpr-use.ll:8
+
+; This function cannot promote to using LDS because of the size of the
+; constant expression use in the function, which was previously not
----------------
We may add 'FIXME' as well to keep these tests tracked as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84081/new/
https://reviews.llvm.org/D84081
More information about the llvm-commits
mailing list