[PATCH] D83946: [flang] Run non-gtest unit tests with lit.

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added a comment.

Thank you David for these patch. 
Dou you mind  to explain why you had to create this new non-gtest unit in the patch.



================
Comment at: flang/test/NonGtestUnit/lit.cfg.py:13
+config.test_format = lit.formats.ExecutableTest()
+
+path = os.path.pathsep.join((config.flang_libs_dir, config.llvm_libs_dir,
----------------
why here I don't need to tweak the path like it is done in flang/test/Unit/lit.cfg.py?


================
Comment at: flang/unittests/Decimal/CMakeLists.txt:11
 
 target_link_libraries(thorough-test
   FortranDecimal
----------------
Should this be removed?


================
Comment at: flang/unittests/Evaluate/CMakeLists.txt:7
 
 target_link_libraries(FortranEvaluateTesting
   LLVMSupport
----------------
Should this be removed?


================
Comment at: flang/unittests/Evaluate/CMakeLists.txt:26
 
-# These routines live in lib/Common but we test them here.
-add_test(UINT128 uint128-test)
-add_test(Leadz leading-zero-bit-count-test)
-add_test(PopPar bit-population-count-test)
-
-add_executable(expression-test
-  expression.cpp
-)
-
-target_link_libraries(expression-test
+add_flang_nongtest_unittest(expression
   FortranCommon
----------------
where are the tests Leadz and PopPar? Are they running?


================
Comment at: flang/unittests/Runtime/CMakeLists.txt:32
 
 target_link_libraries(external-hello-world
   FortranRuntime
----------------
Why this one was not removed like the others?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83946/new/

https://reviews.llvm.org/D83946