[PATCH] D83518: IR: Define byref attribute

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, one nit



================
Comment at: llvm/include/llvm/IR/Argument.h:93
+  /// in-memory ABI type. Otherwise, return nullptr.
+  Type *getPointeeInMemoryValueType() const;
+
----------------
Nit: Comment is broken, I think. Maybe just: `If hasPoint... returns true, the in-memory ABI type is returned, otherwise nullptr.`


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:2606
+}
+
 /// ParseOptionalOperandBundles
----------------
Nice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83518/new/

https://reviews.llvm.org/D83518