[PATCH] D84102: [ARM] Add predicated mla reduction patterns

[Dave Green via Phabricator via llvm-commits]

dmgreen marked an inline comment as done.
dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:1366
+
+  def : Pat<(ARMVMLALVAps tGPREven:$Rda, tGPROdd:$Rdb, (v4i32 MQPR:$val1), (v4i32 MQPR:$val2), (v4i1 VCCR:$pred)),
+            (MVE_VMLALDAVas32 tGPREven:$Rda, tGPROdd:$Rdb, (v4i32 MQPR:$val1), (v4i32 MQPR:$val2), ARMVCCThen, $pred)>;
----------------
simon_tatham wrote:
> I don't see any lowering code that generates the `ARMVMLALVAps` node, but these pattern match it. Did I miss it somewhere?
Oh yeah. I missed a bit in my diffing...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84102/new/

https://reviews.llvm.org/D84102