[PATCH] D83948: [PowerPC] Custom lowering for funnel shifts

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 20 05:28:35 PDT 2020


foad added a subscriber: inouehrs.
foad added a comment.

In D83948#2161728 <https://reviews.llvm.org/D83948#2161728>, @foad wrote:

> Enable combining of PPC-specific shift opcodes.


My rationale is that in PPCTargetLowering::LowerFunnelShift it's correct to use PPCISD::SHL and PPCISD::SRL (instead of the ISD:: versions) precisely because they are defined in the shift-by-bitwidth case. But I think it's safe for BitPermutationSelector to treat them the same as the ISD:: versions. @hfinkel @inouehrs does this seem reasonable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83948/new/

https://reviews.llvm.org/D83948





More information about the llvm-commits mailing list