[PATCH] D83948: [PowerPC] Custom lowering for funnel shifts

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8998
+  // fshr: (X << (BW - (Z % BW))) | (Y >> (Z % BW))
+  // This is simpler than TargetLowering::expandFunnelShift because we can rely
+  // on PowerPC shift by BW being well defined.
----------------
foad wrote:
> RKSimon wrote:
> > Maybe also show the pseudocode as used by PPC for comparison?
> This //is// pseudocode for the PPC expansion. Did you mean, show the more complicated expansion that TargetLowering would have used?
Doh! Sorry about that, I misread it this morning - no need to add anything here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83948/new/

https://reviews.llvm.org/D83948