[PATCH] D78861: [Attributor] Track AA dependency using dependency graph

Luofan Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 20 01:54:50 PDT 2020


bbn updated this revision to Diff 279145.
bbn added a comment.

In previous diff, we use the address of the `ID` to sort the list of the AAs so that we can print them nicer.
But it seems that in different architectures, the address can be different, which can cause the sequence of 
AAs are not deterministic and the test to fail.
So deleted the sorting part and I think now the sequence of AAs printed out should be deterministic, but I
am not sure.

Is there a way to run tests on different architectures (like the buildbot) before committing the patch, so that
I can make sure everything is working great.. (The tests passes on my x86_64 Linux machine, but I am unsure about others)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78861/new/

https://reviews.llvm.org/D78861

Files:
  llvm/include/llvm/Transforms/IPO/Attributor.h
  llvm/lib/Transforms/IPO/Attributor.cpp
  llvm/lib/Transforms/IPO/AttributorAttributes.cpp
  llvm/test/Transforms/Attributor/depgraph.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78861.279145.patch
Type: text/x-patch
Size: 30397 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200720/8bcee40b/attachment.bin>


More information about the llvm-commits mailing list