[PATCH] D83630: [X86] Turn X86DAGToDAGISel::tryVPTERNLOG into a fully custom instruction selector that can handle bitcasts between logic ops

Mon Jul 20 01:45:43 PDT 2020

craig.topper added a comment.

In D83630#2161406 <https://reviews.llvm.org/D83630#2161406>, @RKSimon wrote:

> Do we need additional mask/maskz predicate test coverage?

We currently fail to match those cases before and after this patch. I might look into that as a follow up.

> Do we still need all the ternlog isel patterns in X86InstrAVX512.td?

We definitely need a lot of them. The user facing intrinsics use them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83630/new/

https://reviews.llvm.org/D83630