[PATCH] D83988: AMDGPU/GlobalISel: Start trying to handle AGPR bank

[Madhur Amilkanthwar via Phabricator via llvm-commits]

madhur13490 added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:3140
+
+  // vcc, vgpr -> vgpr
+  return regBankUnion(RB0, RB1);
----------------
kerbowa wrote:
> Fix comment.
I think these comments can be a bit more verbose.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:3144
+
+int AMDGPURegisterBankInfo::getMappingType(const MachineRegisterInfo &MRI,
+                                           const MachineInstr &MI) const {
----------------
This function is returning 'int' but you're receiving it as 'unsigned'. As of now, this is fine but no need to have this discrepancy. I think it should be unsigned uniformly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83988/new/

https://reviews.llvm.org/D83988