[PATCH] D84108: [SimplifyCFG][LoopRotate] SimplifyCFG: disable common instruction hoisting by default, enable late in pipeline

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 20 00:31:16 PDT 2020


lebedev.ri updated this revision to Diff 279137.
lebedev.ri added a comment.

In D84108#2161264 <https://reviews.llvm.org/D84108#2161264>, @mkazantsev wrote:

> I'd suggest splitting this in two parts:
>
> - NFC patch with new options & test updates, but preserving current behavior;
> - One-liner patch to switch default values. This is needed to make revert easier in case if it exposes some problems.


Sure, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84108/new/

https://reviews.llvm.org/D84108

Files:
  llvm/include/llvm/Transforms/Utils/SimplifyCFGOptions.h
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
  llvm/lib/Target/ARM/ARMTargetMachine.cpp
  llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
  llvm/lib/Transforms/Scalar/SimplifyCFGPass.cpp
  llvm/test/Transforms/PGOProfile/chr.ll
  llvm/test/Transforms/PhaseOrdering/loop-rotation-vs-common-code-hoisting.ll
  llvm/test/Transforms/SimplifyCFG/common-code-hoisting.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84108.279137.patch
Type: text/x-patch
Size: 15533 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200720/2523470f/attachment.bin>


More information about the llvm-commits mailing list