[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 19 20:48:06 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:888
+
+  DE.getU64(&Offset, &Err);
+
----------------
hubert.reinterpretcast wrote:
> Please add a comment to indicate that we are skipping the required initial 8 bytes here.
In keeping with the ELF ABI supplement document, we can describe the skipping of the "8 bytes of mandatory fields".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585





More information about the llvm-commits mailing list