[PATCH] D83744: [Attributor] Attributor call site specific AAValueConstantRange

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/Attributor/cb_range.ll:164
+; IS__TUNIT_____ENABLED-SAME: (i32 [[UNKNOWN:%.*]])
+; IS__TUNIT_____ENABLED-NEXT:    [[TMP1:%.*]] = call i32 @test2(i32 [[UNKNOWN]], i32 20) #0, !range !2
+; IS__TUNIT_____ENABLED-NEXT:    [[TMP2:%.*]] = icmp sge i32 [[TMP1]], 30
----------------
kuter wrote:
> fhahn wrote:
> > Shouldn't we also check what the range metadata actually contains?
> > 
> > 
> The positive and negative checks effectively check the upper and the lower bounds of the ranges
> 
We can simply add the check lines manually at the end :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83744/new/

https://reviews.llvm.org/D83744