[PATCH] D83629: [Utils] Check function attributes in update_test_checks

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/utils/update_test_checks.py:56
+  parser.add_argument('--check-attributes', action='store_true',
+                      help='Check "Function Attributes" for functions')
   parser.add_argument('tests', nargs='+')
----------------
sstefan1 wrote:
> jdoerfert wrote:
> > Can we add this to the _cc_test script too (with test). Seems useful when you come from C as well.
> Sure. One concern though. I think this would require running the test with at least `-O1` and `-attributor-enable` flags. 
> I remember @lebedev.ri  having concerns about this. Should I go ahead with that?
Why would that test require attributor?
Just check that some attribute isn't dropped at `-O0`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83629/new/

https://reviews.llvm.org/D83629