[PATCH] D83519: [NewPM] Support optnone under new pass manager

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added inline comments.


================
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:57
 
+class OptNoneInstrumentation {
+public:
----------------
I may probably name this `SkipPassInstrumentation`. But it is up to you.


================
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:65
+
+  bool DebugPM;
+};
----------------
How about calling this `DebugLogging`?


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:27
 #include "llvm/Support/Debug.h"
+#include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/FormatVariadic.h"
----------------
Why need this?


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:270
+  }
+  if (F) {
+    bool HasOptNone = F->hasOptNone();
----------------
```
  if (F && F->hasOptNone()) {
     ...
  }
  return true;
```




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83519/new/

https://reviews.llvm.org/D83519