[PATCH] D84109: [InstCombine] Fix store merge worklist management

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

> There's one side-effect of the worklist order change which could be classified as a regression. An add op gets pushed through a select that at the time is not a umax. We could add a reverse transform that tries to push adds in the reverse direction to restore a min/max, but that seems like a sure way of getting infinite loops :) Seems like something that should best wait on min/max intrinsics.

Yeah, i think we can/should easily undo that, but indeed, until intrinsics are here, it can't not cause infinite loops.

So LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84109/new/

https://reviews.llvm.org/D84109