[PATCH] D83988: AMDGPU/GlobalISel: Start trying to handle AGPR bank

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:3140
+
+  // vcc, vgpr -> vgpr
+  return regBankUnion(RB0, RB1);
----------------
Fix comment.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:3154
+      RegBank = regBankUnion(RegBank, Bank->getID());
+      if (Bank->getID() == AMDGPU::VGPRRegBankID)
+        break;
----------------
Did you mean this to be 'if (RegBank == AMDGPU::VGPRRegBankID)', or else you can move this before the call to regBankUnion?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83988/new/

https://reviews.llvm.org/D83988