[PATCH] D83316: [OpenMPOpt][WIP] Structure for unittests

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 18 17:04:44 PDT 2020


jdoerfert added a comment.

Wow, this required more machinery than I expected.. thanks!

Should we merge this with the `MemoryTransfer` logic so we can test it?



================
Comment at: llvm/unittests/Transforms/IPO/OpenMPOpt/HideMemTransferLatencyTest.cpp:126
+          BasePtrsValues[0]->print(OS);
+          EXPECT_STREQ(OS.str().c_str(), "double* %a");
+          ValueName.clear();
----------------
Don't compare the names. Go through the module and locate the value you want and compare it against the llvm::Value. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83316/new/

https://reviews.llvm.org/D83316





More information about the llvm-commits mailing list