[PATCH] D82341: [PowerPC] add store (load float*) pattern to isProfitableToHoist

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:16030
+    LoadInst *LI = cast<LoadInst>(I);
+    if (!LI->isUnordered() || LI->getPointerOperand()->isSwiftError())
+      return true;
----------------
jsji wrote:
> If these conditions are *copied* from `combineLoadToOperationType`, please also copy comments.
> Otherwise please add comments about why we need these condition, especially `isSwiftError`?
> 
> Also do we have any IR test with SwiftError?
SwiftError attribute can only be applied to pointer to pointer type, so `I->getType()->getTypeID() != Type::FloatTyID` should get rid of this case. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82341/new/

https://reviews.llvm.org/D82341