[PATCH] D83800: Support PC relative relocation on AArch64 and PPC64 in RelocationResolver

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D83800#2159287 <https://reviews.llvm.org/D83800#2159287>, @yuyichao wrote:

> Is there a difference between `R_PPC64_REL32` vs `R_AARCH64_PREL32` vs `R_X86_64_PC32`? I didn't add mask because the x86 one doesn't have it.
>
> I know for some relocations, some bits should be masked off. However, I'm under the impression that for these relocation if the value doesn't fit it would just be an error. Is that the case?


Ideally the interface should report an error. Unfortunately it does not do that (yet). This is OK because RelocationResolver is only used by llvm-dwarfdump and LLD (and also llvm-xray but that use case can be avoided).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83800/new/

https://reviews.llvm.org/D83800