[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast requested changes to this revision.
hubert.reinterpretcast added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:347
+
+  // Used for the fixed or float point parameter type identification.
+  static constexpr uint32_t FixedParaTypeBit = 0x8000'0000;
----------------
// Masks to select leftmost bits for decoding parameter type information.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:348
+  // Used for the fixed or float point parameter type identification.
+  static constexpr uint32_t FixedParaTypeBit = 0x8000'0000;
+  static constexpr uint32_t FloatPointParaTypeBit = 0x4000'0000;
----------------
This is named opposite to its meaning under the usual convention of zero meaning "false" with respect to the indicated property. Suggestion: `ParmTypeIsFloatingBit`.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:349
+  static constexpr uint32_t FixedParaTypeBit = 0x8000'0000;
+  static constexpr uint32_t FloatPointParaTypeBit = 0x4000'0000;
+};
----------------
`ParmTypeFloatingIsDoubleBit`


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:893
+  if (!Err && ParaNum)
+    ParaType = parseParaType(DE.getU32(&Offset, &Err), ParaNum);
+
----------------
I do not believe that it is okay for this to just parse incorrectly when `hasVectorInfo()` is true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585