[PATCH] D83762: [Attributor][WIP] allow multiple branches in followUsesInMBEC

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

We need tests for this, I actually expected existing tests to catch the improvement, is that not the case?



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:601
+  followUsesInContext(AA, A, Explorer, CtxI, Uses, State);
+}
+
----------------
I doubt you want to `indicateOptimisticFixpoint()` here. The initial (=optimistic) state should be what you want. Indicating a fixpoint and continuing to update the state is not a good idea (= might not work).

Use a proper type not auto above and maybe rename `Iter` to either `It` or `StateMapIt` to be more consistent (I think) with the rest. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83762/new/

https://reviews.llvm.org/D83762