[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 17 18:34:37 PDT 2020
jdoerfert added a comment.
In D81031#2159895 <https://reviews.llvm.org/D81031#2159895>, @jhuber6 wrote:
> Fixing errors caused by unused attribute sets. Adding missing attributes to barrier_codegen.cpp.
>
> Should I go ahead and commit this considering the previous was temporarily reverted? Or should I just wait a bit to see if it fails testing again.
If you only did minor modifications and no major problem showed up, the previous LGTM still stands. You should (always) run a full make check-all locally (or better on a server) to verify no other issues are known.
FWIW, it happens that we break bots and patches get reverted. That is not great but also not too bad.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81031/new/
https://reviews.llvm.org/D81031
More information about the llvm-commits
mailing list