[PATCH] D83629: [Utils] Check function attributes in update_test_checks

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

This is great, thanks! We'll have to update all the Attributor tests now :D

LGTM, one minor request below.



================
Comment at: llvm/utils/UpdateTestChecks/common.py:394
+      if attrs:
+        output_lines.append('%s %s: Function Attrs: %s' % (comment_marker, checkprefix, attrs))
       args_and_sig = str(func_dict[checkprefix][func_name].args_and_sig)
----------------
Nit: Maybe add the `;` too.


================
Comment at: llvm/utils/update_test_checks.py:56
+  parser.add_argument('--check-attributes', action='store_true',
+                      help='Check "Function Attributes" for functions')
   parser.add_argument('tests', nargs='+')
----------------
Can we add this to the _cc_test script too (with test). Seems useful when you come from C as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83629/new/

https://reviews.llvm.org/D83629