[PATCH] D83265: [MBP] Use profile count to compute tail dup cost if it is available

[Guozhi Wei via Phabricator via llvm-commits]

Carrot added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:3167
+  SmallVector<MachineBasicBlock *, 8> Succs;
+  for (MachineBasicBlock *Succ : BB->successors()) {
+    if (BlockFilter && !BlockFilter->count(Succ))
----------------
davidxl wrote:
> Carrot wrote:
> > davidxl wrote:
> > > Is this change related?
> > It is not profile count cost model related.
> > It is a different tail dup improvement.
> > Do you want me to send another patch for it?
> Better separate it. Is the contributing to the performance improvement mentioned?
It doesn't cause visible performance impact.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83265/new/

https://reviews.llvm.org/D83265