[PATCH] D83743: [InlineAdvisor] New inliner advisor to replay inlining from optimization remarks

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 15:00:48 PDT 2020


You've also got a Werror in there as well which would get caught by the
sanitizers :)

sources/llvm-project/llvm/lib/Analysis/InlineAdvisor.cpp:390:10: error:
returning address of local temporary object [-Werror,-Wreturn-stack-address]
  return CallSiteLoc.str();
         ^~~~~~~~~~~~~~~~~

I've temporarily reverted this for you thusly:

echristo at athyra ~/s/llvm-project> git push
To github.com:llvm/llvm-project.git
   09fe0c5ab9c..ae08dbc6732  master -> master

Sorry for any inconvenience caused :)

-eric


On Fri, Jul 17, 2020 at 2:59 PM Wenlei He via Phabricator via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> wenlei added a comment.
>
> In D83743#2159588 <https://reviews.llvm.org/D83743#2159588>,
> @stellaraccident wrote:
>
> > The inline-replay.ll test that this added appears to be broken (as was
> noted by the pre-merge check
> https://reviews.llvm.org/harbormaster/unit/view/120108/) and is failing
> in our build.
>
>
> Sorry for the breakage, this wasn't caught in my local build. Taking a
> look.. Feel free to revert to get unblock.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D83743/new/
>
> https://reviews.llvm.org/D83743
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200717/beb94510/attachment.html>


More information about the llvm-commits mailing list