[PATCH] D83275: [llc] (almost) remove `--print-machineinstrs`

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked an inline comment as done.
ychen added inline comments.


================
Comment at: llvm/test/CodeGen/Hexagon/ifcvt-edge-weight.ll:1
-; RUN: llc -march=hexagon -mcpu=hexagonv5 -hexagon-eif=0 -print-machineinstrs=if-converter %s -o /dev/null 2>&1 | FileCheck %s
+; RUN: llc -march=hexagon -mcpu=hexagonv5 -hexagon-eif=0 -print-after=if-converter %s -o /dev/null 2>&1 | FileCheck %s
 ; Check that the edge weights are updated correctly after if-conversion.
----------------
arsenm wrote:
> This test should probably be switched to stop-after and MIR
There is a general problem is that `-printer-after` uses `MachineFunctionPrinterPass`(MachineFunction::print) whereas `-stop-after` uses `MIRPrinter`(in MIR serialization format). The general question is could we just use only of them? thoughts? maybe `MIRPrinter` since it  *seems* the information it prints is a superset of what `MachineFunction::print` prints.

For this particular test, I could use `stop-after` because the check lines are simple. For the next two, using `stop-after` makes the tests fail. How about I add FIXME instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83275/new/

https://reviews.llvm.org/D83275