[PATCH] D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:452
 
+    /// TLS_LOCAL_EXEC_MAT_ADDR = Materialize an addres for TLS global address
+    /// when using local exec access models and prefix instructions are
----------------
I think this might make more sense:
```
/// TLS_LOCAL_EXEC_MAT_ADDR = Materialize an address for TLS global address
/// when using local exec access models, and when prefixed instructions are
/// available. This is used with ADD_TLS to produce an add like PADDI.
```


================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-tls-local-exec.ll:9
+; These test cases are to ensure that when using pc relative memory operations
+; ABI correct code and relocations are produced for Local Exec TLS Model.
+
----------------
nit: `for the Local Exec TLS Model.`


================
Comment at: llvm/test/MC/PowerPC/pcrel-tls-local-exec-address-load-reloc.s:7
+# This test checks that on Power PC we can correctly convert x at tprel
+# into R_PPC64_TPREL34 for local exec relocations with address loaded
+
----------------
nit: `with the address loaded.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83404/new/

https://reviews.llvm.org/D83404