[PATCH] D83923: [MachineOutliner][AArch64] Fix for noreturn functions
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 17 13:19:17 PDT 2020
paquette added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:6113-6115
+ // than one fixup required. The code to handle this asserts currently
+ // because it has not been sufficiently tested for this fixup behavior and
+ // still needs better checks for legal codegen.
----------------
It's actually that it hasn't been implemented, not that it's untested. If you fix up twice you can get wrong code, guaranteed, because you don't know if you'll overflow the instruction.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83923/new/
https://reviews.llvm.org/D83923
More information about the llvm-commits
mailing list