[PATCH] D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct

[Valentin Clement via Phabricator via llvm-commits]

clementval marked an inline comment as done.
clementval added inline comments.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:1085
 
+template <typename T> class DirectiveAttributeVisitor {
+public:
----------------
clementval wrote:
> klausler wrote:
> > resolve-names.cpp is already a large source file.  Does the directive name resolution code have to be in there in order to use things that are local to that file?  If not, maybe all the directive name resolution code could reside elsewhere.
> I think we can move that into a separate file. I'll update the patch. Thanks for the suggestion.
@klausler I would have to move some class declaration from `resolve-name.cpp` to `resolve-name.h`. If this is fine I will split the files. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83998/new/

https://reviews.llvm.org/D83998