[PATCH] D82390: [PowerPC] Fix the implicit operands in PPCInstrInfo::PredicateInstruction()

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 12:14:16 PDT 2020


jsji requested changes to this revision.
jsji added a comment.
This revision now requires changes to proceed.

Agree with Eli in general. Although this **is** the code making that change , current condition code ```if (MI.getOpcode() != OpC) ``` to fix the reg is too general .
We should only fix it when there is real needs.

So maybe set a flag where the implicit operands needs update, and only call the routine when the flag is on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82390/new/

https://reviews.llvm.org/D82390





More information about the llvm-commits mailing list