[PATCH] D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct

Peter Klausler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 10:32:37 PDT 2020


klausler requested changes to this revision.
klausler added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:1085
 
+template <typename T> class DirectiveAttributeVisitor {
+public:
----------------
resolve-names.cpp is already a large source file.  Does the directive name resolution code have to be in there in order to use things that are local to that file?  If not, maybe all the directive name resolution code could reside elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83998/new/

https://reviews.llvm.org/D83998





More information about the llvm-commits mailing list