[PATCH] D83834: Add test utility 'extract'

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/test/tools/extract/basic.test:21-23
+## The first line to the end of bb spans 10 lines.
+# RUN: extract bb - < %s | FileCheck %s --check-prefix=BB --implicit-check-not='{{^}}aa'
+# RUN: extract bb - < %s | count 10
----------------
Does this test that the desired lines are at the desired line numbers? It seems not. The padding lines could be incorrectly printed at the end of the output & it would still pass, right?

I think it'd be better to write this test with exact expected output files & run diff against them. This is a case, in my opinion, where simple golden files seem entirely appropriate - the point of the tool is to produce very specific output, unlike something like opt/llc/etc that produce one of a set of equivalent outputs.


================
Comment at: llvm/tools/extract/.clang-tidy:1
+# Almost identical to the top-level .clang-tidy, except that {Member,Parameter,Variable}Case use camelBack.
+Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,readability-identifier-naming'
----------------
Why does this project have a different format compared to the rest of LLVM?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834